test: expand mockgrbl motion integration coverage#78
Merged
ianbruene merged 1 commit intoJul 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mockgrbl_e2eintegration suite to cover multi-motion queuing and realtime reset behavior that were previously untested.Description
TestDDGoQueuedAbsoluteJogSequencingAgainstMocktointernal/integration/mockgrbl/mockgrbl_e2e_test.go, which queues three absolute machine-coordinate jogs (X,Y,Z) viacontroller.JogToand asserts the mock planner executes them to final(-1, -1, -1)using both mock/stateand the controller snapshot.TestDDGoRealtimeResetDuringJogAgainstMockto the same test file, which starts a long absolute jog, waits for active motion, issues a realtime soft reset viacontroller.Action(grbl.ActionSoftReset), and asserts the mock returns toIdlewith active/queued motion cleared and a sane materialized X position.waitForMockState,waitForControllerState, etc.), tolerances (posTol) for motion assertions, and avoid changing production code or CI workflows.Testing
go test -tags 'serial mockgrbl_e2e' ./internal/integration/mockgrbl, which passed.go test ./..., which passed.go test -tags serial ./internal/transport ./internal/ports ./internal/app ./internal/grbl, which passed.Codex Task