Stabilize mockgrbl e2e timing assertions#77
Merged
ianbruene merged 1 commit intoJul 17, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/responsesor accepting non-specific controller states, causing intermittent failures.Description
waitForMockResponses(t *testing.T, m *mockProcess, timeout time.Duration, pred func([]mockLogEntry) bool) []mockLogEntrythat pollsGET /responsesand fails with useful diagnostics if the predicate is not met.internal/integration/mockgrbl/mockgrbl_e2e_test.goto callwaitForMockResponses(...)and wait for both[MSG:jogLIM]anderror:15before asserting the final safe mock state.MachineStateto be exactlyIdleinstead of accepting any non-Jogstate, while keeping the existing final status request.internal/integration/mockgrbl/mockgrbl_e2e_test.goand preserve all build tags and production behavior.Testing
go test -tags 'serial mockgrbl_e2e' ./internal/integration/mockgrbland it passed (ok github.com/ianbruene/ddgo/internal/integration/mockgrbl).go test ./...and it passed for all packages.go test -tags serial ./internal/transport ./internal/ports ./internal/app ./internal/grbland they passed.internal/integration/mockgrbl/mockgrbl_e2e_test.go.gofmt -w internal/integration/mockgrbl/mockgrbl_e2e_test.go,go test -tags 'serial mockgrbl_e2e' ./internal/integration/mockgrbl,go test ./..., andgo test -tags serial ./internal/transport ./internal/ports ./internal/app ./internal/grbl.Codex Task