Add mockgrbl jog completion and limit rejection tests#76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mockgrbl_e2eintegration suite to cover two high-value jog behaviors: naturalJogTocompletion at a target and out-of-boundsJogTorejection without starting motion.Description
TestDDGoJogToEndpointCompletesAgainstMockwhich issuescontroller.JogTo(ctx, "X", -1.0, 60), waits for the mock to reachIdlewith no active move/queue and machine X near-1.0, then verifies the DDGocontrollersnapshot matches the completed position.TestDDGoJogLimitRejectionAgainstMockwhich issues an out-of-boundscontroller.JogTo(ctx, "X", -999.0, 60), asserts the mock remainsIdlewith no motion and machine X near the baseline, and verifies the mock emitted a jog-limit response like[MSG:jogLIM]/error:15.mockLogEntry, shared toleranceposTol, genericgetJSON/fetchJSONhelpers,responses/eventsaccessors, richerdumpDiagnostics, and bounded polling helperswaitForMockStateandwaitForControllerStatethat avoid fixed long sleeps and provide last-state diagnostics on timeout.linux && serial && mockgrbl_e2ebuild tags, use the real serial transport via the harness, and do not modify mockgrbl or production controller behavior.Testing
go test -tags 'serial mockgrbl_e2e' ./internal/integration/mockgrbland the integration tests passed.go test ./...and the full test suite passed.go test -tags serial ./internal/transport ./internal/ports ./internal/app ./internal/grbland those package tests passed.Codex Task