Restore full Linux desktop packaging#75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
scripts/package-linux-app.shwhich accepts<ddgo-binary> <mockgrbl-binary> <output-dir>, recreates the output layout, copiesddgo/mockgrbl, discovers and copiesldd-resolved shared libraries intolib/, copies Qt plugin directories fromqmake -query QT_INSTALL_PLUGINS(includingplatforms/libqxcb.so,xcbglintegrations,imageformats,styles, etc.), writesrun-ddgo.sh, and writesREADME-artifact.txtwhile excluding core loader/glibc libs.scripts/verify-linux-dist.shwhich asserts the staged layout (ddgo,mockgrbl,run-ddgo.sh, non-emptylib/,plugins/platforms/libqxcb.so,README-artifact.txt), runslddchecks fornot foundonddgoandplugins/platforms/libqxcb.so(both with the bundledLD_LIBRARY_PATH/QT_PLUGIN_PATH), runsmockgrbl -h, and prints the final layout..github/workflows/cd.ymlbuild-linuxjob to install additional runtime packaging helpers (qtbase5-dev-tools,libxcb-*,file), build raw binaries intodist/build-linux, callscripts/package-linux-app.shandscripts/verify-linux-dist.sh, then archivedist/DDGo-linux-amd64asdist/DDGo-linux-amd64.tar.gzand upload artifactDDGo-linux-amd64.docs/RELEASING.mdto document the new artifact layout and usage, the launcher behavior (LD_LIBRARY_PATH,QT_PLUGIN_PATH,QT_QPA_PLATFORM_PLUGIN_PATH), and the compatibility caveat that the artifact is built onubuntu-latestand is not guaranteed portable to every distro.Changed files:
.github/workflows/cd.yml,docs/RELEASING.md,scripts/package-linux-app.sh,scripts/verify-linux-dist.sh.Artifact layout produced and documented:
The runtime launcher is
run-ddgo.shwhich setsLD_LIBRARY_PATH="$ROOT/lib",QT_PLUGIN_PATH="$ROOT/plugins", andQT_QPA_PLATFORM_PLUGIN_PATH="$ROOT/plugins/platforms"before exec-ingddgo.Bundling strategy:
lddonddgoand on copied Qt plugin.sofiles to collect non-system shared libraries intolib/, copy Qt plugin directories discovered viaqmake, and intentionally exclude the dynamic loader and core glibc/libs (e.g.ld-linux*,libc,libpthread,libm,libdl,librt).Testing
bash -n scripts/package-linux-app.sh scripts/verify-linux-dist.shand the workflow YAML loaded successfully with a Ruby YAML parse check.go test ./...succeeded andgo test -tags serial ./internal/transport ./internal/ports ./internal/app ./internal/grblsucceeded.go build -o /tmp/mockgrbl ./cmd/mockgrblsucceeded and script files were made executable.ldd-based bundling was skipped locally becauseqmake/qmake-qt5is not installed in this environment, but the GitHub Actionsbuild-linuxjob installsqtbase5-dev-toolsso full packaging/verification will run in CI.Remaining limitations
ubuntu-latestand bundles Qt/runtime libraries as provided by that runner, so compatibility with older or very different distributions is limited by the runner's glibc/system ABI and is not guaranteed portable to every Linux distro.--helppath; verification stops atldd/layout checks and runningmockgrbl -h.Codex Task