Restore Linux release artifact#74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mockgrblsmoke/integration steps unchanged while adding explicit Linux packaging to the CD flow.Description
build-linuxjob to.github/workflows/cd.ymlthat installs Linux build deps, builds the GUIddgowith-tags 'miqt serial', buildsmockgrbl, packages them intodist/DDGo-linux-amd64.tar.gz, verifies the archive, and uploads it as theDDGo-linux-amd64artifact withif-no-files-found: error.releasejob in.github/workflows/cd.ymlto depend on thebuild-linuxjob, require the Linux tarball during tagged-release validation, and include it in the GitHub Release upload listing.docs/RELEASING.mdto document the new Linux artifact and the archive layout and build commands..github/workflows/cd.yml,docs/RELEASING.md.DDGo-linux-amd64containingDDGo-linux-amd64.tar.gzwithlinux-amd64/ddgo,linux-amd64/mockgrbl, andlinux-amd64/README-artifact.txt.GOOS=linux GOARCH=amd64 CGO_ENABLED=1 go build -tags 'miqt serial' -trimpath -ldflags='-s -w' -o dist/linux-amd64/ddgo ./cmd/ddgo,GOOS=linux GOARCH=amd64 CGO_ENABLED=1 go build -trimpath -ldflags='-s -w' -o dist/linux-amd64/mockgrbl ./cmd/mockgrbl, andtar -C dist -czf dist/DDGo-linux-amd64.tar.gz linux-amd64.Testing
go test ./...succeeded andgo test -tags serial ./internal/transport ./internal/ports ./internal/app ./internal/grblsucceeded locally.go build -tags serial -o /tmp/ddgo ./cmd/ddgoandgo build -o /tmp/mockgrbl ./cmd/mockgrblsucceeded and/tmp/mockgrbl -hprinted usage successfully.ruby -e 'require "yaml"; YAML.load_file(".github/workflows/cd.yml")'succeeded andgit diff --checkreported no issues.miqt-tagged Linux build and dependency install (apt-get install qtbase5-dev) failed in this environment due to blocked package repositories, so full-tags 'miqt serial'Linux artifact build was not validated locally but the CD job installsqtbase5-devon the runner; CI will perform the full Linux build onubuntu-latestduring tagged releases.Codex Task