Add mockgrbl CI integration-test foundation#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mockgrblso integration tests can run in CI without hardware or UI dependencies.Description
scripts/ci_mockgrbl_smoke.shthat buildscmd/mockgrbl, starts it with a unique PTY symlink and debug HTTP address, waits for the symlink andGET /statereadiness, prints diagnostics on failure, and guarantees process cleanup viatrap.internal/integration/mockgrblwithmockgrbl_e2e_test.go(build taglinux && serial && mockgrbl_e2e) that builds/launches the mock per-test, waits on/state, returns the serial symlink and HTTP base URL, captures logs, and ensures cleanup and diagnostics.app.Controllerto exercise status polling, a jog-then-stop scenario, and assert range-based machine positions rather than precise timings.cmd/mockgrblPTY handling by configuring the slave in raw mode (cmd/mockgrbl/pty_linux.go) and tolerate transient PTYEIOreads while preserving EOF/closed behavior (cmd/mockgrbl/main.go).Testing
Ran
go test ./...which succeeded for the repo packages andgo test -tags serial ./internal/transport ./internal/ports ./internal/app ./internal/grblwhich succeeded.Executed the smoke script
scripts/ci_mockgrbl_smoke.shwhich reported readiness (mockgrbl smoke test ready).Executed the integration suite
go test -tags 'serial mockgrbl_e2e' ./internal/integration/mockgrblwhich passed locally.Commits included:
e2fbe5a—ci: smoke test mockgrbl startup,657106b—test: add mockgrbl integration harness, and5887a3b—test: exercise DDGo against mockgrbl, and CI uses Ubuntu-only steps in the existingtestjob rather than adding a new job.Known remaining gaps: no UI-level integration yet, no macro/probe/contour scenarios over the mock, the mock intentionally approximates some firmware behaviors, and integration tests assert ranges (tolerances) rather than exact real-time positions.
Codex Task