Fix README: correct token IDs for LLaDA tokenizer - #2
Open
usovmv wants to merge 1 commit into
Open
Conversation
The README examples used token IDs from the Llama 3 tokenizer (vocab_size=128256), but LLaDA uses its own tokenizer with vocab_size=126080. Token 128000 is out of bounds for the model's embedding matrix (126464 rows), causing an assertion failure in ggml_compute_forward_get_rows and a crash. Changes: - Bash example: 128000,... → 2372,341,268,7706,300,11406,30 - Python snippet: full model path + trust_remote_code=True (huggingface-cli can't resolve 'LLaDA-8B-Instruct' without the GSAI-ML namespace) - C++ API example: correct token IDs matching the example prompt - Added warning about using the correct tokenizer per model Verified: the corrected tokens produce 'The capital of France is Paris.'
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to specify the correct tokenizers for the LLaDA and Dream models. It updates the CLI, Python, and C++ code examples with the correct token IDs and Hugging Face model path (including trust_remote_code=True). There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README examples used token IDs from the Llama 3 tokenizer (vocab_size=128256), but LLaDA uses its own tokenizer with vocab_size=126080. Token 128000 is out of bounds for the model's embedding matrix (126464 rows), causing an assertion failure in ggml_compute_forward_get_rows and a crash.
Changes:
Verified: the corrected tokens produce 'The capital of France is Paris.'