Wrapup full#4
Merged
Merged
Conversation
…hors in the vignette
* microtour inserted * observers added (needed?)
Adapt .multiSelectionResponsive to recent changes in iSEE
…variables effectively used
… panel is to be used
Adapt to new roxygen2 and scrapper replacement for scuttle functions
Update docs
csoneson
approved these changes
May 18, 2026
Member
csoneson
left a comment
csoneson
left a comment
There was a problem hiding this comment.
LGTM. Just one thing: what about including something like
#' @export
setMethod(".hideInterface", "SampleIdentificationCenter", function(x, field) {
if (field %in% c(iSEE:::.selectRowSource, iSEE:::.selectRowRestrict, iSEE:::.selectRowDynamic)) {
TRUE
} else {
callNextMethod()
}
})
to hide the row selection (I don't think it's relevant at the moment).
Contributor
Author
|
puh, why not. It is actually to avoid that people select something that has clearly no function/no return to be expected. |
Member
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalizing the implementation, all things should be in as needed (also added some tests to have a good level of coverage..)
This one is basically the updated version of #1 , "just done"