Bump version to 2.4, ensure both release zips build automatically - #211
Merged
Merged
Conversation
release.yml only ran 'make dist', so the compiled-only zip was the only asset ever auto-attached to a release; the source-lua zip (needed for EdgeTX 2.11+) had to be built and uploaded by hand. Also broaden the release tag trigger since published tags haven't consistently used a 'v' prefix (e.g. 2.4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
2.4release was tagged and published without any assets attached, and the in-appVERSIONstring still said2.3.0. Root causes:local VERSION = "2.3.0"insrc/SCRIPTS/TELEMETRY/iNav.luawas never bumped before tagging, so the widget itself would report the wrong version even once assets were added.release.ymlonly runsmake dist, which builds the compiled-lua zip. It never ranmake dist-lua(the uncompiled source zip needed for EdgeTX 2.11+), so that second asset — present on past releases — had to be built and uploaded by hand every time.release.ymltag trigger isv*only, but published tags haven't been consistent (v2.2.0,v.2.3.0, and now plain2.4), so a tag like2.4never fires the workflow at all.Changes
VERSIONto2.4to match the published tag.release.yml/ci.yml: build bothmake distandmake dist-luaso both zips are produced (and uploaded, forrelease.yml) automatically.release.yml: also trigger on bare numeric version tags ([0-9]+.[0-9]+*), not justv*.Verified
tx15.lua/tx16s.lua480x320 and 800x480 layouts from Adding support for the Radiomaster TX15 and other 480x320px color screen radios #190/Add 800x480 layout support for RadioMaster TX16S MK3 #202/Jetrell wants to have an attitude #203) and confirmed both are present in the compiled zip and the version string is2.4in the source zip.make dist dist-lua(the exact command the workflows now run) succeeds in one invocation.Note
The already-published
2.4release currently points at 4c6af52 (before this version bump) and has no assets. Assets built from this branch will be attached to that release separately; not moving the tag since the release has no assets yet to conflict with.Test plan
ci.yml) run on this PR produces both a compiled and a source zip artifact