[FCC] Adapt RefitProc to support ILD@FCC - #81
Merged
Conversation
tmadlener
reviewed
Aug 20, 2026
tmadlener
left a comment
tmadlener
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. It will still mainly work for ILD (like) geometries only, but I think generalizing this can also come later, e.g. in the migration of the whole processor.
Did you verify this runs with both versions of ILD?
Contributor
Author
|
I have successfully used it for ILD@FCC and for ILD@ILC, I have tested it with the |
jmcarcell
reviewed
Aug 20, 2026
Contributor
Author
|
I have verified the refactored version as well |
Contributor
|
ci no longer finding |
tmadlener
enabled auto-merge (squash)
August 21, 2026 18:20
tmadlener
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
subDetIDsfromdd4hepdetmod instead of relying on hardcoded oncesENDRELEASENOTES