Adding truth info for FCC-ee ILD model, add vertex resolutions as inp… by armin-ilg · Pull Request #188 · iLCSoft/ILDConfig

armin-ilg · 2026-07-20T13:01:15Z

…ut arguments, update vertex detector naming scheme to be compliant also with FCC-SEED VXD (backwards compatible with CLD VXD), updating CT_MAX_DIST value to use the same as CLD with smaller beam pipe

BEGINRELEASENOTES

Enable usage of FCC-SEED VXD with updated VXD system strings (backwards compatible with CLD VXD), see Adding FCC-SEED as option to all detectors and refactor IDEA/ALLEGRO vertex detector key4hep/k4geo#612
Updating CT_MAX_DIST to correct value (like in CLD)
Enabling additonal low cell angle step in conformal tracking (like in CLD)
ENDRELEASENOTES

…ut arguments, update vertex detector naming scheme to be compliant also with FCC-SEED VXD (backwards compatible with CLD VXD), updating CT_MAX_DIST value to use the same as CLD with smaller beam pipe

armin-ilg · 2026-07-20T13:01:41Z

@Victor-Schwan : As discussed, here's the PR with the changes to ILDConfig

Victor-Schwan · 2026-07-28T13:21:31Z

I have just realized that I have already a MCRecoTruthLinker with the correct collection names in my fork (see https://github.com/Victor-Schwan/ILDConfig/tree/fcc-tracking). Further, I assume we wanna place the MCRecoTruthLinker in a HighLevelReco_FCCee similar to the ILC reconstruction (see

ILDConfig/StandardConfig/production/HighLevelReco/HighLevelReco.py

Lines 206 to 262 in 279b180

    
           MyRecoMCTruthLinker = MarlinProcessorWrapper("MyRecoMCTruthLinker") 
        
           MyRecoMCTruthLinker.ProcessorType = "RecoMCTruthLinker" 
        
           MyRecoMCTruthLinker.Parameters = { 
        
               "CalohitMCTruthLinkName": ["CalohitMCTruthLink"], 
        
               "ClusterCollection": ["PandoraClusters"], 
        
               "ClusterMCTruthLinkName": ["ClusterMCTruthLink"], 
        
               "FullRecoRelation": ["true"], 
        
               "KeepDaughtersPDG": ["22", "111", "310", "13", "211", "321"], 
        
               "MCParticleCollection": ["MCParticle"], 
        
               "MCParticlesSkimmedName": ["MCParticlesSkimmed"], 
        
               "MCTruthClusterLinkName": ["MCTruthClusterLink"], 
        
               "MCTruthRecoLinkName": ["MCTruthRecoLink"], 
        
               "MCTruthTrackLinkName": ["MCTruthMarlinTrkTracksLink"], 
        
               "RecoMCTruthLinkName": ["RecoMCTruthLink"], 
        
               "RecoParticleCollection": ["PandoraPFOs"], 
        
               "SimCaloHitCollections": [ 
        
                   "BeamCalCollection", 
        
                   "LHCalCollection", 
        
                   "LumiCalCollection", 
        
                   CONSTANTS["ECalSimHitCollections"], 
        
                   CONSTANTS["HCalSimHitCollections"], 
        
                   "YokeBarrelCollection", 
        
                   "YokeEndcapsCollection", 
        
               ], 
        
               "SimCalorimeterHitRelationNames": [ 
        
                   "EcalBarrelRelationsSimRec", 
        
                   "EcalEndcapRingRelationsSimRec", 
        
                   "EcalEndcapsRelationsSimRec", 
        
                   "HcalBarrelRelationsSimRec", 
        
                   "HcalEndcapRingRelationsSimRec", 
        
                   "HcalEndcapsRelationsSimRec", 
        
                   "RelationLHcalHit", 
        
                   "RelationMuonHit", 
        
                   "RelationLcalHit", 
        
                   "RelationBCalHit", 
        
               ], 
        
               "SimTrackerHitCollections": [ 
        
                   "VXDCollection", 
        
                   "SITCollection", 
        
                   "FTD_PIXELCollection", 
        
                   "FTD_STRIPCollection", 
        
                   "TPCCollection", 
        
                   "SETCollection", 
        
               ], 
        
               "TrackCollection": ["MarlinTrkTracks"], 
        
               "TrackMCTruthLinkName": ["MarlinTrkTracksMCTruthLink"], 
        
               "TrackerHitsRelInputCollections": [ 
        
                   "VXDTrackerHitRelations", 
        
                   "SITTrackerHitRelations", 
        
                   "FTDPixelTrackerHitRelations", 
        
                   "FTDSpacePointRelations", 
        
                   "TPCTrackerHitRelations", 
        
                   "SETSpacePointRelations", 
        
               ], 
        
               "UseTrackerHitRelations": ["true"], 
        
               "UsingParticleGun": [str(using_particle_gun).lower()], 
        
           }

) and not in the ILDReconstruction.py. This is also already present in my fork. I guess it may make more sense to take the MCRecoTruthLinker from my fork?

Co-authored-by: Victor Schwan <162138084+Victor-Schwan@users.noreply.github.com>

armin-ilg · 2026-08-12T12:27:12Z

I have just realized that I have already a MCRecoTruthLinker with the correct collection names in my fork (see https://github.com/Victor-Schwan/ILDConfig/tree/fcc-tracking). Further, I assume we wanna place the MCRecoTruthLinker in a HighLevelReco_FCCee similar to the ILC reconstruction (see

ILDConfig/StandardConfig/production/HighLevelReco/HighLevelReco.py

Lines 206 to 262 in 279b180

MyRecoMCTruthLinker = MarlinProcessorWrapper("MyRecoMCTruthLinker")

MyRecoMCTruthLinker.ProcessorType = "RecoMCTruthLinker"

MyRecoMCTruthLinker.Parameters = {

"CalohitMCTruthLinkName": ["CalohitMCTruthLink"],

"ClusterCollection": ["PandoraClusters"],

"ClusterMCTruthLinkName": ["ClusterMCTruthLink"],

"FullRecoRelation": ["true"],

"KeepDaughtersPDG": ["22", "111", "310", "13", "211", "321"],

"MCParticleCollection": ["MCParticle"],

"MCParticlesSkimmedName": ["MCParticlesSkimmed"],

"MCTruthClusterLinkName": ["MCTruthClusterLink"],

"MCTruthRecoLinkName": ["MCTruthRecoLink"],

"MCTruthTrackLinkName": ["MCTruthMarlinTrkTracksLink"],

"RecoMCTruthLinkName": ["RecoMCTruthLink"],

"RecoParticleCollection": ["PandoraPFOs"],

"SimCaloHitCollections": [

"BeamCalCollection",

"LHCalCollection",

"LumiCalCollection",

CONSTANTS["ECalSimHitCollections"],

CONSTANTS["HCalSimHitCollections"],

"YokeBarrelCollection",

"YokeEndcapsCollection",

],

"SimCalorimeterHitRelationNames": [

"EcalBarrelRelationsSimRec",

"EcalEndcapRingRelationsSimRec",

"EcalEndcapsRelationsSimRec",

"HcalBarrelRelationsSimRec",

"HcalEndcapRingRelationsSimRec",

"HcalEndcapsRelationsSimRec",

"RelationLHcalHit",

"RelationMuonHit",

"RelationLcalHit",

"RelationBCalHit",

],

"SimTrackerHitCollections": [

"VXDCollection",

"SITCollection",

"FTD_PIXELCollection",

"FTD_STRIPCollection",

"TPCCollection",

"SETCollection",

],

"TrackCollection": ["MarlinTrkTracks"],

"TrackMCTruthLinkName": ["MarlinTrkTracksMCTruthLink"],

"TrackerHitsRelInputCollections": [

"VXDTrackerHitRelations",

"SITTrackerHitRelations",

"FTDPixelTrackerHitRelations",

"FTDSpacePointRelations",

"TPCTrackerHitRelations",

"SETSpacePointRelations",

],

"UseTrackerHitRelations": ["true"],

"UsingParticleGun": [str(using_particle_gun).lower()],

}

) and not in the ILDReconstruction.py. This is also already present in my fork. I guess it may make more sense to take the MCRecoTruthLinker from my fork?

Okay, yes that makes totally sense. Shall I remove the truth link stuff from this PR?

Victor-Schwan · 2026-08-12T13:52:51Z

Okay, yes that makes totally sense. Shall I remove the truth link stuff from this PR?

In my opinion, that makes the most sense. If you need it, just cherrypick it from my PR. This way, git is aware of it and there shouldn't be any conflicts later on

tmadlener · 2026-08-13T09:42:01Z

So for clarification: This PR will introduce the vertex resolution setting bits and #193 will do the truth linking?

Victor-Schwan · 2026-08-13T09:48:10Z

So for clarification: This PR will introduce the vertex resolution setting bits and #193 will do the truth linking?

There are many things in #193 that are necessary for FCC tracking. I've created a draft PR so that others can see it and, for example, to avoid implementing TruthLinking twice. However, it might make sense to merge TruthLinking beforehand in a separate PR. Let me know if you wish to do so

tmadlener · 2026-08-13T09:48:48Z

However, it might make sense to merge TruthLinking beforehand in a separate PR. Let me know if you wish to do so

That sounds like a good idea

…ndled in a separate PR

armin-ilg · 2026-08-14T12:02:11Z

So for clarification: This PR will introduce the vertex resolution setting bits and #193 will do the truth linking?

There are many things in #193 that are necessary for FCC tracking. I've created a draft PR so that others can see it and, for example, to avoid implementing TruthLinking twice. However, it might make sense to merge TruthLinking beforehand in a separate PR. Let me know if you wish to do so

I removed the truth linking from this PR 👍

armin-ilg · 2026-08-14T12:03:29Z

All comments addressed now

Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>

tmadlener · 2026-08-14T15:07:48Z

CI seems to be as happy as we expect it to be. @Victor-Schwan any preference from your side on the order of merging things?

Victor-Schwan · 2026-08-14T16:19:53Z

As this is based on #197, #197 should be merged first. I assume you also take care of merging #194 and then it is up to you what you prefer :)

tmadlener · 2026-08-19T14:47:30Z

I have resolved the conflicts via a merge. Can you give this a quick look again when you have time to make sure that didn't do anything unexpected?

tmadlener · 2026-08-20T12:47:25Z

This looks good, but we would like to defer merging this until we have established the technical bits of running performance studies that @Victor-Schwan is currently working on. Otherwise we run the danger of introducing yet another source of potential issues (even though nothing in here looks like it should be one).

In light of ILD being removed again from the switch to the SEED VXD in key4hep/k4geo#612, do you need this to be merged to master immediately @armin-ilg? Otherwise, we would merge this once the technical baseline is established and I will keep this PR mergeable, resp. fix merge conflicts as they arise so that you can effectively consider this PR as done from your side.

armin-ilg · 2026-08-20T12:50:52Z

This looks good, but we would like to defer merging this until we have established the technical bits of running performance studies that @Victor-Schwan is currently working on. Otherwise we run the danger of introducing yet another source of potential issues (even though nothing in here looks like it should be one).

In light of ILD being removed again from the switch to the SEED VXD in key4hep/k4geo#612, do you need this to be merged to master immediately @armin-ilg? Otherwise, we would merge this once the technical baseline is established and I will keep this PR mergeable, resp. fix merge conflicts as they arise so that you can effectively consider this PR as done from your side.

No, I don't think we need to have this merged instantly, I'd be happy to wait.

Adding truth info for FCC-ee ILD model, add vertex resolutions as inp…

0422a8d

…ut arguments, update vertex detector naming scheme to be compliant also with FCC-SEED VXD (backwards compatible with CLD VXD), updating CT_MAX_DIST value to use the same as CLD with smaller beam pipe

armin-ilg mentioned this pull request Jul 20, 2026

Adding FCC-SEED as option to all detectors and refactor IDEA/ALLEGRO vertex detector key4hep/k4geo#612

Open

8 tasks

Victor-Schwan reviewed Jul 28, 2026

View reviewed changes

Comment thread StandardConfig/production/ILDReconstruction.py

Victor-Schwan reviewed Jul 28, 2026

View reviewed changes

Comment thread StandardConfig/production/ILDReconstruction.py Outdated

Victor-Schwan reviewed Jul 28, 2026

View reviewed changes

Comment thread StandardConfig/production/ILDReconstruction.py Outdated

Victor-Schwan reviewed Jul 28, 2026

View reviewed changes

Comment thread StandardConfig/production/ILDReconstruction.py Outdated

Update StandardConfig/production/ILDReconstruction.py

303def9

Co-authored-by: Victor Schwan <162138084+Victor-Schwan@users.noreply.github.com>

tmadlener reviewed Aug 13, 2026

View reviewed changes

Comment thread StandardConfig/production/Tracking/TrackingDigi_FCCeeMDI.py

Comment thread StandardConfig/production/Tracking/TrackingReco_FCCeeMDI.py Outdated

Comment thread StandardConfig/production/Tracking/TrackingReco_FCCeeMDI.py

Victor-Schwan mentioned this pull request Aug 14, 2026

[FCC] Add HighLevelReco Sequence for FCC #197

Merged

armin-ilg added 2 commits August 14, 2026 13:55

Address comments, remove truth matching for FCC-ee as this will be ha…

79fad74

…ndled in a separate PR

Merge branch 'master' into master

09b8da3

tmadlener reviewed Aug 14, 2026

View reviewed changes

Comment thread StandardConfig/production/Tracking/TrackingReco_FCCeeMDI.py

Fix missing definition of algorithm

6becb42

Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>

Merge branch 'master' into truth-info-fcc

c0cf856

Fix formatting

3b83b87

Uh oh!

Conversation

armin-ilg commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

armin-ilg commented Jul 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Victor-Schwan commented Jul 28, 2026

Uh oh!

armin-ilg commented Aug 12, 2026

Uh oh!

Victor-Schwan commented Aug 12, 2026

Uh oh!

tmadlener commented Aug 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Victor-Schwan commented Aug 13, 2026

Uh oh!

tmadlener commented Aug 13, 2026

Uh oh!

armin-ilg commented Aug 14, 2026

Uh oh!

armin-ilg commented Aug 14, 2026

Uh oh!

Uh oh!

tmadlener commented Aug 14, 2026

Uh oh!

Victor-Schwan commented Aug 14, 2026

Uh oh!

tmadlener commented Aug 19, 2026

Uh oh!

tmadlener commented Aug 20, 2026

Uh oh!

armin-ilg commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

armin-ilg commented Jul 20, 2026 •

edited

Loading