Skip to content

Add --ci flag to the types command to allow checking for out of date types with ci/scripts#262

Merged
adrai merged 1 commit into
i18next:mainfrom
pjrobertson:add-ci-flag-to-types
Jun 2, 2026
Merged

Add --ci flag to the types command to allow checking for out of date types with ci/scripts#262
adrai merged 1 commit into
i18next:mainfrom
pjrobertson:add-ci-flag-to-types

Conversation

@pjrobertson

Copy link
Copy Markdown
Contributor

Fixes #261

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test NOTE: 2 tests still failing from previously
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@adrai adrai merged commit 69fa50f into i18next:main Jun 2, 2026
8 checks passed
@adrai

adrai commented Jun 2, 2026

Copy link
Copy Markdown
Member

Merged and released in v1.59.0 🚀

Thanks again for the clean implementation and tests, @pjrobertson! I also added docs for types --ci (command options + a CI/CD snippet) in a follow-up commit. You can now drop the git diff scripting in favor of:

- name: Check i18n Resources Schema
  run: npx i18next-cli types --ci

FYI the 2 test failures you noted in the checklist didn't reproduce here — the full suite (1059 tests) passes locally and the flag was verified end-to-end. If you still see those 2 failing on your machine, let me know which ones and I'll take a look.

@pjrobertson

Copy link
Copy Markdown
Contributor Author

I've created a separate bug report, it may be a false positive because my setup is not quite right - feel free to close if it's irrelevant

@pjrobertson pjrobertson deleted the add-ci-flag-to-types branch June 2, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve types call to allow failure if new types are generated

2 participants