fftls: added ClientTLSConfigMergingSystemCAs for HTTP clients that ne… - #238
Merged
EnriqueL8 merged 3 commits intoJul 27, 2026
Merged
Conversation
IvanNik
force-pushed
the
fftls-client-merging-cas
branch
from
July 24, 2026 20:32
98dd301 to
cd8699f
Compare
… public CAs Signed-off-by: IvanNik <ivan.nikulin@kaleido.io>
IvanNik
force-pushed
the
fftls-client-merging-cas
branch
from
July 24, 2026 20:55
cd8699f to
803d465
Compare
IvanNik
marked this pull request as ready for review
July 24, 2026 21:09
onelapahead
approved these changes
Jul 24, 2026
onelapahead
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thanks Ivan
… public CAs Signed-off-by: IvanNik <ivan.nikulin@kaleido.io>
IvanNik
force-pushed
the
fftls-client-merging-cas
branch
from
July 27, 2026 14:48
44119f0 to
f6ae832
Compare
… public CAs Signed-off-by: IvanNik <ivan.nikulin@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includeSystemCAs(defaultfalse).caFile/ca) is set andincludeSystemCAs: true, merge that CA into the system cert pool instead of replacingRootCAs.Config
caFile/casetincludeSystemCAsfalsefalse: custom CA only (existing).true: system pool + custom CA.Example:
Security
ClientCAstrust unless intentional.