feat: refactor to use diagnostics providers#6
Merged
srivastava-diya merged 4 commits intoJun 1, 2026
Merged
Conversation
Updated comment for clarity on onDidChangeContent handler.
jdesrosiers
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds JSON schema validation using
@hyperjump/json-schemaand@hyperjump/json-schema-errorsChanges
In
SyntaxValidation.ts: Extracted the syntax diagnostic logic from JsonValidation.ts into a standalone functiongetSyntaxDiagnostics(textDocument, parseErrors): Diagnostic[]. No server, no connection just input and output.In
SchemaValidation.ts: A standalone functiongetSchemaDiagnostics(textDocument, tree, schemaUri, documentMap)that handles schema validation. It reads the $schema field from the document, parses the JSON, runs it through @hyperjump/json-schema's validate() with BASIC output format, and maps errors back to document ranges . Also contains MatchingSchemaCollector , an EvaluationPlugin that hooks into evaluation lifecycle via afterKeyword to collect per-instance-location schema matches. Not used for validation itself, but will power future features like hover tooltips and completions.In
JsonValidation.ts: it acts as the orchestrator now. Calls bothgetSyntaxDiagnosticsandgetSchemaDiagnostics, and sends a single combined sendDiagnostics call thus prevents overwriting.Integrated
@hyperjump/json-schema-errorsfor better error messages. Added aformatErrorhelper that recursively formats nested anyOf/oneOf alternatives with indentation.Tests added: valid case, invalid case with message content assertions, and anyOf and OneOf formatting case.
Screenshots