refactor: better auto default for data frame budget - #946
Merged
Conversation
|
Small nit on Also as a naive proposal, |
Sruhvx-jpg
added a commit
to Sruhvx-jpg/h2
that referenced
this pull request
Aug 23, 2026
Problem HTTP/2 flow control limits DATA payload bytes, but not the framing overhead from excessive numbers of small frames. A peer could fragment data into many tiny frames, causing disproportionate memory usage from queued events while remaining within flow-control windows. Solution Backport the framing overhead budget and empty frame handling from master (hyperium#935, hyperium#940, hyperium#942, hyperium#945, hyperium#946) to the 0.3.x maintenance branch. Validation Ran the full test suite and added regression integration tests in stream_states.rs.
Instead of choosing a specific small default constant, the small data frame overhead budget will now be calculated based on the configured connection window size. Setting the budget directly will skip the default auto value.
seanmonstar
force-pushed
the
sean/orvlpvnqoqqq
branch
from
August 24, 2026 12:05
40eab67 to
c09964f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of choosing a specific small default constant, the small data frame overhead budget will now be calculated based on the configured connection window size. Setting the budget directly will skip the default auto value.
Closes #944