Sprint 2: first-party offers vertical slice - #7
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rsistence Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Sprint 2 plan (
docs/superpowers/plans/2026-07-06-sprint-2-offers.md): the first-party offers slice, end to end on the Sprint 0-1 foundation.offerIdwire field, kebab-case placement slugs)OfferDefinition+ pureresolveOffer(UTC schedule window computed on read, inclusive start / exclusive end, priority wins) +OfferMetricsStoreport;ConfigStoregainsgetOffersruntime.offer_events(impressions/clicks; deliberately no read-modify-write — see Fix lost-update race on achievement progress counters #3)GET /config-plane/offersbehind the shared-secret guard, seed ("Welcome to Promocean" onhomepage-banner)getOfferswith TTL cache + stale-on-errorGET /v1/placements/:slug/offer(records impressions; metric failures never fail the response) +POST /v1/offers/:id/click, both param-bounded per repo conventiongetPlacementOffer, fire-and-forgetclickOffer, localStorage dismissal with SSR-safe fallback<Placement>with CTA click tracking, accessible dismiss, and an http(s) scheme allowlist on creative URLs (stored-XSS fix caught by security review mid-sprint)Test plan
Review notes
Nine tasks, each through implement → review → fix → re-review, plus a final whole-branch review (verdict: ready with fixes; param-validation fix applied in
873e02cand re-approved). Follow-ups filed/updated: #6 (offer impression accuracy: dismissed-offer impressions, retry duplicates, priority-tie determinism), #4 and #5 extended with offers-path scope.🤖 Generated with Claude Code