Sprint 10: hardening & release readiness — backlog burn-down, reactive identify, npm rehearsal - #27
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d stats totals, race coverage; drop dead stores (migration 0009) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…idator, drop dead placement param
…and NULL-recurrence probes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…anup, remote guard Fixes reviewer findings on the verify-lifecycles.ts script: probe 1 now distinguishes the lifecycles' typed ValidationError from any other thrown error instead of treating any throw as a pass; probe 3's fixture cleanup runs in a finally and gains a positive-inclusion control row; probe 2 pages explicitly instead of relying on limit: -1; the script refuses to run against a non-local DATABASE_URL (unless --allow-remote) and refuses to guess a fallback connection string. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d deps Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…G.md Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…et, ttl floor, tiebreak, docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Sprint 10 plan (
docs/superpowers/plans/2026-07-09-sprint-10-hardening-release.md) — the consolidation sprint: the entire seven-issue backlog closed, one cross-cutting integrator fix, and the npm release pipeline rehearsed end to end.identify()(the sprint's one feature): SDKonUserChangelistener (fires only on real identity change, per-listener exception guard — retrofitted ontoonUnlocktoo);PromoceanProvidermirrors the identity into context (usePromoceanUser()hook;usePromocean()unchanged); every identity-gated widget (Leaderboard, RewardsStore, BadgeCabinet) live-updates on login-after-load and user switching — no more remount-via-key. Demo gains a "Switch user" control exercising the path live; e2e asserts it.userIdparam removed (route + OpenAPI)apps/cms/scripts/verify-lifecycles.ts(admin-session relation-shape probe, duplicate-staticCode scan, legacy-NULL recurrence probe with opt-in--fix; localhost blast-radius guard) — both probes found no real defects: all relation shapes fire the uniqueness checks; NULL recurrence behaves identically to'none'DELIVERED_CLAIMS_TTL_DAYS, default 30, floor-clamped to 1); per-tick cost documented; stats totals chunked per 50 events with cross-chunk DISTINCT dedupuser_streakscomposite PK (migration 0009, additive-safe, survival-tested on populated tables); sharedisValidUserId; ordering-tiebreak sweep (one addition: coupon validate selection)EventStore/PgEventStore,ProgressStore.setProgressworkspace:*rewritten); published to a local verdaccio + scratch-project install/import smoke passed with zero findings;RELEASING.mddocuments the flow and the one manual step for going public (npm org +NPM_TOKENsecret, then dispatchrelease.yml)The one that mattered
The final whole-branch review caught a live release hazard the rehearsal itself had missed:
changeset publishfilters only onpackage.json.privateand never consults the changesetignorelist (verified against the CLI source) — the first real release dispatch would have published the GPL-licensed internal packages (core, adapter-db, adapter-strapi, config, api) to the public registry withsrc/included. Fixed inf371754: all five are nowprivate: true, RELEASING.md's incorrect safety claim corrected, and an explicitpnpm publish -rwarning added. The dry-run now lists exactly the three MIT packages.Behavior notes for existing consumers
identify()/re-identify — apps that remounted via akeyprop can remove that workaround (README migration note). Context internals changed butusePromocean()is signature-identical.Error(previously aPromoceanApiErrorcarrying a stale earlier 5xx status). All-5xx runs are unchanged.GET /v1/statsaccepts offset-form ISO datetimes (+02:00); placements GET no longer accepts/documents auserIdquery param (it was consumed by nothing since Sprint 5).user_streaks) is additive-safe; migration runs at boot as usual.private: true.Test plan
pnpm --filter cms verify:lifecyclesReview notes
Eight tasks through the full gate cycle (three fix waves: widgets no-op-notify discriminating test, cms script error-type assertions + blast-radius guards, and the final wave above) plus the whole-branch review — verdict ready to merge after
f371754, all seven issue closures confirmed warranted. Follow-up filed: #26 (Docker dist-list derivation, turbo typecheck self-build dep). Remaining v1.x after this sprint: config-as-code CLI, React Native SDK.Closes #5
Closes #15
Closes #18
Closes #20
Closes #21
Closes #23
Closes #24
🤖 Generated with Claude Code