Skip to content

Add: run deferred_notify_demo onboard on a2a3 - #1584

Open
ChaoWao wants to merge 1 commit into
hw-native-sys:mainfrom
ChaoWao:test/deferred-notify-onboard
Open

Add: run deferred_notify_demo onboard on a2a3#1584
ChaoWao wants to merge 1 commit into
hw-native-sys:mainfrom
ChaoWao:test/deferred-notify-onboard

Conversation

@ChaoWao

@ChaoWao ChaoWao commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Why this was sim-only, and why that was wrong

#1568 left deferred_notify_demo marked platforms(["a2a3sim"]) because it failed when I temporarily widened it and ran a full onboard sweep.

That sweep carried no --ignore sets, so it included the SDMA demos that ci.yml:600 quarantines out of the general sweep — precisely because they are only correct in isolation. By the standard #1580 has since written into the testing skill, that was an invalid baseline. The demo was condemned on evidence that does not stand.

Re-test against a CI-shaped sweep

Mirroring ci.yml:607 ($SDMA_IGNORE $HEAVY_IGNORE, no --runtime, so the real dispatcher runs), onboard a2a3:

Run scope deferred_notify_demo
1 examples tests/st PASS 14.5 s, devices=[9, 1]
2 examples tests/st PASS 14.3 s, devices=[3, 5]
3 examples/a2a3 (ran to completion, exit 0) PASS 13.8 s, devices=[7, 9]

Three independent runs, three different device pairs. Runs 1 and 2 were cut short at 60–70% by the task-submit daemon restarting (exit=137) — infrastructure, not a test: both showed 55 passed / 0 failed at the point of interruption. Run 3 used a narrower scope and completed cleanly.

Also still green under a2a3sim (PASS 14.7 s), and passes standalone at max_diff=0.000e+00.

Why it was always plausible

Nothing in the demo is sim-specific. It uses the same CommDomain / CommBufferSpec path as async_notify_demo, which has always run onboard; a line-by-line diff shows the only real delta is that deferred additionally writes a peer mailbox in the comm window.

Scope

a2a3 only. The a5 copy stays ["a5sim"] — this box is a2a3 silicon, so widening it there would be an unverified claim. Worth a look by someone with a5 hardware, since the same reasoning likely applies.

🤖 Generated with Claude Code

hw-native-sys#1568 left this demo sim-only because it failed in a full onboard sweep.
That sweep carried no `--ignore` sets, so it included the SDMA demos that
`ci.yml:600` quarantines out of the general sweep precisely because they
are only correct in isolation — an invalid baseline, by the standard
hw-native-sys#1580 has since written into the testing skill.

Re-tested against a CI-shaped sweep (`$SDMA_IGNORE $HEAVY_IGNORE`,
mirroring `ci.yml:607`): the demo passes onboard a2a3 in three
independent runs on three different device pairs — [7, 9], [3, 5],
[9, 1] — at ~14 s each, alongside the rest of `examples/a2a3`. It also
still passes under a2a3sim, and passed standalone at `max_diff=0.000e+00`.

Nothing in the demo is sim-specific: it uses the same CommDomain /
CommBufferSpec path as `async_notify_demo`, which has always run onboard,
and differs only in also writing a peer mailbox in the comm window.

The a5 copy stays sim-only — this box is a2a3 silicon, so widening it
there would be an unverified claim.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7e562812-483d-4b8d-97fd-4c0923d30110

📥 Commits

Reviewing files that changed from the base of the PR and between 33e5450 and 1f01e37.

📒 Files selected for processing (1)
  • examples/a2a3/tensormap_and_ringbuffer/deferred_notify_demo/test_deferred_notify_demo.py

📝 Walkthrough

Walkthrough

The deferred notify demo now documents coverage for onboard and sim environments and runs on both the a2a3 and a2a3sim platforms.

Changes

Deferred notify coverage

Layer / File(s) Summary
Expand deferred notify platform coverage
examples/a2a3/tensormap_and_ringbuffer/deferred_notify_demo/test_deferred_notify_demo.py
The module description and pytest platform marker now include onboard a2a3 coverage alongside a2a3sim.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a bunny with a test to run,
Onboard and sim now share the sun.
a2a3 joins the hopping queue,
Deferred notices ring out true!
Two platforms, one happy crew.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: enabling deferred_notify_demo to run onboard on a2a3.
Description check ✅ Passed The description is directly related to the changeset and explains the a2a3 onboarding change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant