Testa5ci

[doraemonmj]

No description provided.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 81c38449-f99b-4832-a57d-595d0f0f05cb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The GitHub Actions workflow is renamed from CI to TESTCI. Multiple packaging, unit-test, simulation, profiling, and A2A3 hardware jobs are removed from .github/workflows/ci.yml.

Changes

CI workflow changes

Layer / File(s)	Summary
Workflow identity .github/workflows/ci.yml	The workflow name changes from CI to TESTCI.
Removed CI jobs .github/workflows/ci.yml	Packaging smoke, non-hardware unit-test, simulation, profiling, and A2A3 hardware jobs are removed before detect-changes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• hw-native-sys/simpler#1356: Modifies the A2A3 hardware CI jobs that this PR removes.
• hw-native-sys/simpler#1360: Updates steps within the A2A3 hardware CI jobs removed here.
• hw-native-sys/simpler#1373: Reworks allocation and dispatch in the A2A3 jobs removed here.

Poem

A rabbit hops through workflows bright,
“TESTCI” now names the testing night.
Smoke tests vanish, hardware sleeps,
While detect-changes onward creeps.
Carrots cheer the cleaner run! 🐇

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is too vague and reads like an internal branch name, so it does not clearly describe the change.	Use a concise, descriptive title that summarizes the main workflow change, such as renaming the CI workflow or removing test jobs.
Description check	❓ Inconclusive	No pull request description was provided, so there is no meaningful summary of the changes.	Add a brief description of the workflow update and the main jobs or steps that were removed or renamed.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/ci.yml (1)

58-93: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Deleting the packaging, unit-test, sim/onboard scene, and profiling jobs removes nearly all CI coverage — and leaves the profiling comment block orphaned.

Two problems in this range:

1. The removed jobs are documented as the enforcement mechanism for existing contracts: docs/getting-started.md and docs/python-packaging.md both state that the packaging-matrix job enforces the 5×2 install-mode combinations via tools/verify_packaging.sh. Dropping them silently invalidates that documentation and leaves only pre-commit + detect-changes gating merges. If this pruning is intentional, update docs/ci.md, docs/getting-started.md, and docs/python-packaging.md in the same PR; if it is scaffolding for the testa5ci experiment, restore the jobs before merge.
2. Lines 59-93 are a ~35-line rationale comment for the now-deleted profiling-flags-smoke job. Keeping the commentary without the job it documents is misleading; remove it along with the job (or keep the job).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml around lines 58 - 93, Resolve the CI pruning
consistently: either restore the removed packaging, unit-test, sim/onboard
scene, and profiling jobs, or update docs/ci.md, docs/getting-started.md, and
docs/python-packaging.md to remove claims about their coverage and enforcement.
Also remove the orphaned profiling rationale comment surrounding the
profiling-flags-smoke configuration if that job remains deleted; otherwise
restore the corresponding job it documents.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Line 1: Restore the workflow name from TESTCI to CI in the workflow
declaration, preserving the existing status-check and workflow_run identifiers
and documentation references.

---

Outside diff comments:
In @.github/workflows/ci.yml:
- Around line 58-93: Resolve the CI pruning consistently: either restore the
removed packaging, unit-test, sim/onboard scene, and profiling jobs, or update
docs/ci.md, docs/getting-started.md, and docs/python-packaging.md to remove
claims about their coverage and enforcement. Also remove the orphaned profiling
rationale comment surrounding the profiling-flags-smoke configuration if that
job remains deleted; otherwise restore the corresponding job it documents.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a692f573-dba0-47d6-ac28-cd90f859b6de

📥 Commits

Reviewing files that changed from the base of the PR and between f8e2067 and ebe583e.

📒 Files selected for processing (1)

• .github/workflows/ci.yml

[coderabbitai]

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Renaming the workflow CI → TESTCI breaks required status checks and docs.

Branch protection rules / rulesets and any workflow_run triggers keyed on the workflow name CI will no longer match, so merges can pass without gating. Docs also still refer to CI in docs/ci.md. If this is a temporary debug rename for the testa5ci branch, please revert before merge.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 1, Restore the workflow name from TESTCI to
CI in the workflow declaration, preserving the existing status-check and
workflow_run identifiers and documentation references.