Update: make dense dependency diagnostics debug-only - #1448
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe dependency-degree threshold was renamed for debug logging, and dense fanout/fanin diagnostics in both runtime variants now emit at debug level. Dummy-task documentation was updated to describe the four-scene orchestration and case-4 dependency pattern. ChangesDependency diagnostics
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/st/a2a3/tensormap_and_ringbuffer/dummy_task/test_dummy_task.py (1)
98-100: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy liftThe mirrored dense tests do not verify the diagnostic contract.
tests/st/a2a3/tensormap_and_ringbuffer/dummy_task/test_dummy_task.py#L98-L100: assert INFO produces no dense messages and DEBUG produces exactly one fanout and one fanin message.tests/st/a5/tensormap_and_ringbuffer/dummy_task/test_dummy_task.py#L94-L96: add the same diagnostic assertions or reference shared log-validation coverage.Based on PR objectives, diagnostic level and exactly-once behavior are explicit acceptance criteria.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/st/a2a3/tensormap_and_ringbuffer/dummy_task/test_dummy_task.py` around lines 98 - 100, Add diagnostic assertions to the dense-dependency tests in tests/st/a2a3/tensormap_and_ringbuffer/dummy_task/test_dummy_task.py:98-100 and tests/st/a5/tensormap_and_ringbuffer/dummy_task/test_dummy_task.py:94-96, verifying INFO emits no dense messages while DEBUG emits exactly one fanout and one fanin message; alternatively, reuse shared log-validation coverage in both sites.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/st/a2a3/tensormap_and_ringbuffer/dummy_task/test_dummy_task.py`:
- Around line 98-100: Add diagnostic assertions to the dense-dependency tests in
tests/st/a2a3/tensormap_and_ringbuffer/dummy_task/test_dummy_task.py:98-100 and
tests/st/a5/tensormap_and_ringbuffer/dummy_task/test_dummy_task.py:94-96,
verifying INFO emits no dense messages while DEBUG emits exactly one fanout and
one fanin message; alternatively, reuse shared log-validation coverage in both
sites.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 7e448581-70dc-46e3-bd54-9d190d1e5e0f
📒 Files selected for processing (8)
src/a2a3/runtime/tensormap_and_ringbuffer/runtime/pto_orchestrator.cppsrc/a2a3/runtime/tensormap_and_ringbuffer/runtime/pto_runtime2_types.hsrc/a5/runtime/tensormap_and_ringbuffer/runtime/pto_orchestrator.cppsrc/a5/runtime/tensormap_and_ringbuffer/runtime/pto_runtime2_types.htests/st/a2a3/tensormap_and_ringbuffer/dummy_task/kernels/orchestration/dummy_task_orch.cpptests/st/a2a3/tensormap_and_ringbuffer/dummy_task/test_dummy_task.pytests/st/a5/tensormap_and_ringbuffer/dummy_task/kernels/orchestration/dummy_task_orch.cpptests/st/a5/tensormap_and_ringbuffer/dummy_task/test_dummy_task.py
f29d052 to
017f66e
Compare
- Keep fanin and fanout threshold checks but emit them at DEBUG level for both a2a3 and a5 runtimes. - Exercise high-degree fanin and fanout wiring in dummy-task scenes. This keeps the diagnostic available on demand without adding noise to normal runtime logs.
…DEBUG) Post-merge follow-up: upstream hw-native-sys#1448 kept the print_stats 'Ring %d' / 'last_task_alive' lines at LOG_INFO_V0 while removing the dep_pool detail. Per this branch's original plan (commit demoting print_stats/print_queues to DEBUG), demote those two upstream-kept lines to LOG_DEBUG. Upstream's deletions (dep_pool / FaninPool dense diagnostics) stay deleted; nothing new is added. Reviewed: src/a2a3/runtime/host_build_graph/runtime/scheduler/pto_scheduler.cpp
Trim low-signal LOG_* call sites across the runtime and platform layers, keeping the diagnostics that trace program flow or failures: - Flow / lifecycle / summary logs kept at INFO; per-item (per-tensor, per-arg) detail demoted to LOG_DEBUG; failure paths stay LOG_ERROR / LOG_WARN. Loader / device-runner load-path diagnostics kept at their original levels. - AICPU hot paths (per-task / per-scope dispatch loops) carry no logs (codestyle rule 7); DFX collectors keep their buffer-level init/flush diagnostics and telemetry counters. - STRACE, LOG_RUNTIME_FAILURE and ACL logging left untouched. - Log-only support removed with its logs (bookkeeping counters, dump scaffolding); genuine out-of-scope strip collateral restored (unused-parameter removals, blank-line deletions). Rebased onto upstream/main; dense dependency diagnostics follow upstream's debug-only / removed decisions (hw-native-sys#1448), completion follows the polling mechanism (hw-native-sys#1435).
Trim low-signal LOG_* call sites across the runtime and platform layers, keeping the diagnostics that trace program flow or failures: - Flow / lifecycle / summary logs kept at INFO; per-item (per-tensor, per-arg) detail demoted to LOG_DEBUG; failure paths stay LOG_ERROR / LOG_WARN. Loader / device-runner load-path diagnostics kept at their original levels. - AICPU hot paths (per-task / per-scope dispatch loops) carry no logs (codestyle rule 7); DFX collectors keep their buffer-level init/flush diagnostics and telemetry counters. - STRACE, LOG_RUNTIME_FAILURE and ACL logging left untouched. - Log-only support removed with its logs (bookkeeping counters, dump scaffolding); genuine out-of-scope strip collateral restored (unused-parameter removals, blank-line deletions). Rebased onto upstream/main; dense dependency diagnostics follow upstream's debug-only / removed decisions (hw-native-sys#1448), completion follows the polling mechanism (hw-native-sys#1435). Co-Authored-By: vegetabledoww <114059112+vegetabledoww@users.noreply.github.com>
Trim low-signal LOG_* call sites across the runtime and platform layers, keeping the diagnostics that trace program flow or failures: - Flow / lifecycle / summary logs kept at INFO; per-item (per-tensor, per-arg) detail demoted to LOG_DEBUG; failure paths stay LOG_ERROR / LOG_WARN. Loader / device-runner load-path diagnostics kept at their original levels. - AICPU hot paths (per-task / per-scope dispatch loops) carry no logs (codestyle rule 7); DFX collectors keep their buffer-level init/flush diagnostics and telemetry counters. - STRACE, LOG_RUNTIME_FAILURE and ACL logging left untouched. - Log-only support removed with its logs (bookkeeping counters, dump scaffolding); genuine out-of-scope strip collateral restored (unused-parameter removals, blank-line deletions). Rebased onto upstream/main; dense dependency diagnostics follow upstream's debug-only / removed decisions (hw-native-sys#1448), completion follows the polling mechanism (hw-native-sys#1435). Co-Authored-By: vegetabledoww <114059112+vegetabledoww@users.noreply.github.com>
Trim low-signal LOG_* call sites across the runtime and platform layers, keeping the diagnostics that trace program flow or failures: - Flow / lifecycle / summary logs kept at INFO; per-item (per-tensor, per-arg) detail demoted to LOG_DEBUG; failure paths stay LOG_ERROR / LOG_WARN. Loader / device-runner load-path diagnostics kept at their original levels. - AICPU hot paths (per-task / per-scope dispatch loops) carry no logs (codestyle rule 7); DFX collectors keep their buffer-level init/flush diagnostics and telemetry counters. - STRACE, LOG_RUNTIME_FAILURE and ACL logging left untouched. - Log-only support removed with its logs (bookkeeping counters, dump scaffolding); genuine out-of-scope strip collateral restored (unused-parameter removals, blank-line deletions). Rebased onto upstream/main; dense dependency diagnostics follow upstream's debug-only / removed decisions (#1448), completion follows the polling mechanism (#1435). Co-authored-by: vegetabledoww <114059112+vegetabledoww@users.noreply.github.com>
Summary
Testing
pip install --no-build-isolation -e .dense dependencymessages