feat(qwen3): use device embedding for prefill - #84
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughQwen3 prefill execution now passes token IDs and embedding weights to device kernels, allowing host embeddings to be omitted. Core batching types, engine and worker paths, compiled buffers, dispatch signatures, and tests were updated accordingly. ChangesDevice-side embedding prefill
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Engine
participant Worker
participant Qwen3PrefillHost
participant DeviceKernel
Engine->>Worker: create PrefillBatch with token IDs
Worker->>Qwen3PrefillHost: pass token IDs and optional embeddings
Qwen3PrefillHost->>DeviceKernel: forward input IDs and embed weight
DeviceKernel->>DeviceKernel: embed token IDs and execute prefill
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2f05d62 to
bba5c70
Compare
bba5c70 to
9429c12
Compare
| device=runtime_model.runtime.device, | ||
| ) | ||
| embeddings = None | ||
| if not self._executor.supports_device_embedding: |
There was a problem hiding this comment.
supports_device_embedding还有必要么,可以做成一个通用流程?
Summary
Validation