Chore/v0.1 debt closure#9
Open
hungthinh1104 wants to merge 5 commits into
Open
Conversation
…orcement - enforce backend boundary: remove api/src cross-imports from worker modules using @ba-helper/api alias - refactor(worker): standardize typed job error handling with job-error-classifier - refactor(worker): isolate AiModule and PrismaModule to worker-local scopes - refactor(review): make review coverage gate ids deterministic - refactor(embedding): inject embedding runtime config via DI token - docs(document): annotate STALE as projection-only state and add invariant test - refactor(web): remove local capability guesses in review-decision-form - ci(domain-packs): add verify:domain-packs and boundary grep check to CI - docs(project): align v0.1 state with implemented invariants in AGENTS.md
…closure - Created `@ba-helper/backend-runtime` physical package to host shared infrastructure, replacing illegal cross-package imports between apps/api and apps/worker. - Removed path alias `@ba-helper/api/*` masking from tsconfig.base.json. - Re-wired API and Worker module resolution to safely consume runtime providers. - Fixed frontend Role permission casting in `review-decision-form.tsx`. - Cleaned up Docker project name to drop the test suffix. - Refactored Dockerfiles to correctly compile backend-runtime as part of CI builds. - Cleaned up temporary debug logs and validation scripts. This commit achieves a clean architecture state and exit-0 builds across the workspace, marking the completion of the v0.1 invariant hardening phase.
…closure - Created `@ba-helper/backend-runtime` physical package to host shared infrastructure, replacing illegal cross-package imports between apps/api and apps/worker. - Removed path alias `@ba-helper/api/*` masking from tsconfig.base.json. - Re-wired API and Worker module resolution to safely consume runtime providers. - Fixed frontend Role permission casting in `review-decision-form.tsx`. - Cleaned up Docker project name to drop the test suffix. - Refactored Dockerfiles to correctly compile backend-runtime as part of CI builds. - Cleaned up temporary debug logs and validation scripts. This commit achieves a clean architecture state and exit-0 builds across the workspace, marking the completion of the v0.1 invariant hardening phase.
- Replace barrel imports (`../../index`) with direct relative imports across `backend-runtime` to fix Jest test suite crashes (A circular dependency has been detected inside PrismaModule). - Enforce string conversion for `errorCode` in `RunImpactAnalysisUseCase` to prevent Zod validation failures on the frontend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Scope
What does this PR do?
Checklist
pnpm typecheckandpnpm demo:golden-path.