Fix installer sample content creation error - #175
Merged
Conversation
kilgor-trout-c22
requested review from
luke- and
marc-farre
and removed request for
marc-farre
June 8, 2026 11:40
luke-
approved these changes
Jun 9, 2026
Contributor
|
@kilgor-trout-c22 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue humhub/humhub-internal#1221
Events::onSampleDataInstall()attaches sample comments via the removed polymorphicobject_model/object_idproperties, which now throwsUnknownPropertyExceptionon a clean install fromhumhub:develop(v1.19) with sample content enabled. Content addons now attach viacontent_id(as core's own installer already does).