[v1.19] Update for HumHub 1.19#697
Open
yurabakhtin wants to merge 27 commits into
Open
Conversation
PHP CS Fixer 2026-01-29-094222
Remove deprecations
Add aria-label attribute for icon-only buttons
# Conflicts: # docs/CHANGELOG.md # models/CalendarEntry.php # module.json
CalDAV authenticates statelessly per request (HTTP Basic / token). Since the twofa module moved to the core user gate system, the former twofa.beforeCheck opt-out no longer exists, and a CalDAV request kept the session enabled — so the gate dispatcher classified it as a full-page request and could intercept the sync for affected users (e.g. 2FA enforced). CalDavController::beforeAction now sets enableSession = false, so the request is classified as a stateless API request and the gates leave it untouched (consistent with the REST module). The dead twofa.beforeCheck listener is removed. Requires core >= 1.19.
Exempt CalDAV from the core user gates by disabling the session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/humhub/enterprise-theme/issues/213