Skip to content

Allow administrator to change the name of the SSO link#47

Open
andresrs wants to merge 6 commits into
humanmade:masterfrom
andresrs:sso-link-name
Open

Allow administrator to change the name of the SSO link#47
andresrs wants to merge 6 commits into
humanmade:masterfrom
andresrs:sso-link-name

Conversation

@andresrs

Copy link
Copy Markdown

No description provided.

@hm-linter hm-linter Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (1 error, 1 warning).

@andresrs andresrs left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepared for review.

@andresrs andresrs left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review

@rmccue rmccue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We use the wpsimplesaml_log_in_text filter usually, but I'm OK with adding an option for this as well.

Comment thread inc/admin/namespace.php Outdated
It's the correct way to handle text attributes.
@andresrs andresrs requested a review from rmccue October 28, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants