Shared in Slack markers#646
Merged
Merged
Conversation
Surface when a post has been shared into Slack as a subtle, email-silent marker inline in its comment stream — another signal of reach when a post otherwise gets no comments. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
When the H2 side resolved a sharer (public shares only), render "Shared by <name> in #channel on Slack" via the slack.shared_by field; unattributed and non-public markers are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Attributed public shares now read "Shared by @username in #channel on Slack" with @username linking to the sharer's H2 profile (AuthorLink). Also give a marker that ends the thread a short tail so the rounded terminal dot clears the node's mask and shows, matching trailing comments. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
joehoyle
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands the "Shared in Slack" comment-stream markers on
main.What happened
The original PR (#645) was merged into
releaseinstead ofmain. h2's release pipeline (release.yml) only rebuilds the compiled assets on a push tomain— so the bundle onreleasewas never regenerated. The server side shipped fine (markers appear in wp-admin and in the REST payload), but the production JS bundle has noSlackMentioncode, so nothing renders in the comment stream.This puts the same source onto
mainsorelease.ymlrebuildsreleasewith the feature compiled in. Once merged, the hmn.md composer pin gets bumped to the newreleasebuild.No code changes vs #645 — identical source, cherry-picked (
07454c0d,dee5978b,bbf9d9c,a891da9).