Rebuild bundle for hyphenated @mention fix#641
Closed
svandragt wants to merge 1 commit into
Closed
Conversation
The mention matcher fix in 319fb41 changed src/matchers.js but did not regenerate the committed build/ assets, which are gitignored and force-added. Altis serves the committed bundle, so the source fix had no effect until rebuilt. Rebuild from current release: the main bundle now contains /@([\w-]+)/. Only h2.js changed hash; chunks and CSS rebuilt byte-identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #640.
#640 fixed the mention matcher in
src/matchers.js(/@(\w+)/→/@([\w-]+)/) so that @mentions of users with hyphenated slugs (e.g.@dominic-huxley) link correctly. Butbuild/is gitignored and the committed bundles are force-added, so asrc/change alone never updates what ships. Altis serves the committed bundle, so the fix had no effect — the live regex was still\w+.Change
Rebuilt from current
release:build/h2.49c2cbfe…js→build/h2.f9cacc65…js— the new main bundle contains/@([\w-]+)/(verified; old/@(\w+)/is gone).build/production-asset-manifest.json—h2.jsnow points at the new bundle.Note for maintainers
Because
build/is in.gitignore, source-only mention/UI PRs won't take effect until the bundle is rebuilt and force-added. Worth considering a CI build step or removingbuild/from.gitignoreso this can't be missed again.🤖 Generated with Claude Code