Removing includes for amounts because it is very slow - #2
Open
mpmenne wants to merge 5 commits into
Open
Conversation
AlexBeznoss
suggested changes
Aug 5, 2019
AlexBeznoss
left a comment
AlexBeznoss
left a comment
There was a problem hiding this comment.
Since we add it by our selves we can remove it without any doubts, but this is one of the main dependencies of our platform, so it should have green build anyway.
Removing unnecessary balance methods
Collaborator
Author
|
@AlexBeznoss Great point. Fixing now. |
…utus into removing-includes-for-amounts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is really slow if you eager load all of the amounts on a
Plutus::Entry.I'm removing those includes so that it goes faster.