feat: throttle npm:renovate, fix duplicate packageRules key, share presets - #61
Merged
Conversation
…esets Pin npm:renovate to an explicit mise version and throttle its updates to weekly via renovate-config's chain-debounce preset, referenced from .renovaterc.json's extends array. This also fixes a bug from an earlier commit: the rule had been added as a second top-level "packageRules" key, which JSON silently lets the later declaration overwrite, leaving the file's original go-hk.yml/mise.toml.jinja/pytest rules as the only ones actually applied. Also extract the vulnerabilityAlerts block and "major updates" grouping rule out of go-renovaterc.json in favor of extending renovate-config's new presets/vulnerability-alerts.json and presets/major-updates-ungrouped.json fragments, since those were byte-identical duplicates of renovate-config/default.json. The genuinely different policy (minimumReleaseAge, narrower automerge scope, gomod grouping) stays local and unshared. Extract the Copier-owned-files exclusion rules (hk.pkl, mise.toml) out of template/.renovaterc.json into presets/copier-owned-files.json, so the file stamped into Go consumer repos is a two-line extends instead of inlining ~10 lines of packageRules. Reaches consumers on their next copier update. Bump the hk-config pin to v1.3.0 and switch hk.pkl's renovate_config_validator step to spread in the new Base.renovate module (overriding its glob locally), instead of hand-rolling the same check command hk-config now provides as a shared building block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm:renovateto an explicit mise version, throttled to weekly via renovate-config'schain-debouncepreset (referenced from.renovaterc.json'sextends)."packageRules"key in.renovaterc.jsonsilently overrode the file's original rules (JSON, not merged presets).vulnerabilityAlertsblock and "major updates" grouping out ofgo-renovaterc.jsonin favor of renovate-config's new shared preset fragments — the genuinely different policy (minimumReleaseAge, narrower automerge scope,gomodgrouping) stays local.template/.renovaterc.jsonintopresets/copier-owned-files.json(reaches the 6 Go consumer repos on their nextcopier update).hk-configpin to v1.3.0 and adopt its newBase.renovatemodule.Test plan
hk check --allpasses locally, includingrenovate_config_validatoragainst all 4 renovate config files