Skip to content

fix(select): allow relative URLs for advanced select apiUrl #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
delfuego wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(select): allow relative URLs for advanced select apiUrl #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/plugins/select/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,7 +1610,13 @@ class HSSelect extends HSBasePlugin<ISelectOptions> implements ISelect {

private async apiRequest(val = '', signal?: AbortSignal): Promise<any> {
try {
const url = new URL(this.apiUrl);
let url;
try {
url = new URL(this.apiUrl, window.location.origin);
} catch {
console.error('Invalid API URL:', this.apiUrl);
return null;
}
const queryParams = new URLSearchParams(this.apiQuery ?? '');
const options = this.apiOptions ?? {};
const tempOptions = { ...(options as any) } as RequestInit;
Expand Down