Skip to content

Refine sample report formatting and add sample Report ID - #180

Open
hrtechifyed wants to merge 6 commits into
mainfrom
fix/sample-report-format-and-id
Open

Refine sample report formatting and add sample Report ID#180
hrtechifyed wants to merge 6 commits into
mainfrom
fix/sample-report-format-and-id

Conversation

@hrtechifyed

Copy link
Copy Markdown
Owner

What changed

  • Tightens spacing and alignment on sample-advisory-report.html without changing report content or functionality.
  • Adds a dedicated sample-only presentation layer scoped to .sample-advisory-page.
  • Fixes the Executive Summary status area to render as an explicit 2×2 desktop grid instead of inheriting oversized stacked cards.
  • Reduces legacy section/card dead space, aligns section headings and explanatory copy to a common left edge, and gives roadmap items explicit aligned timeline-card treatment.
  • Preserves responsive/print behavior with one-column mobile fallbacks and print overrides.
  • Adds a visible Sample Report ID using the same GWHR-YYYY-MMDD-XXXX shape as production IDs, with a clearly sample-only SM01 suffix.
  • Passes the same sample Report ID into the downloadable sample PDF context.
  • Does not call /api/report-id, so viewing/downloading a sample never consumes or advances the production Report ID sequence.

Regression protection

  • Extends presentation contract tests for sample spacing, grid rules, timeline alignment, sample-ID construction, and production-ID isolation.
  • Adds Playwright coverage for desktop alignment/spacing, Report ID consistency, mobile one-column behavior, and horizontal-overflow protection.
  • Adds the new sample-specific CSS/JS paths and browser spec to the Executive Assessment workflow.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
growwithhr-version2 dd39217 Aug 18 2026, 01:33 PM

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd39217a68

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +59 to +60
.sample-advisory-page .section {
padding: clamp(44px, 5vw, 64px) 0;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Raise the specificity of the sample layout overrides

The existing body[data-active-nav="sample"] .section rule in css/19-presentation-polish.css has higher specificity than this selector, so at the new test's 1440px viewport the section padding remains 96px rather than the intended maximum of 64px. The same specificity problem leaves .executive-profile-strip at six columns and keeps explanatory paragraphs centered, causing the newly added desktop Playwright assertions for padding, five columns, and heading alignment to fail; these overrides need at least the specificity of the existing body[data-active-nav="sample"] rules.

Useful? React with 👍 / 👎.

Comment thread js/sample-advisory-pdf.js
Comment on lines +18 to +20
const year = String(safeDate.getUTCFullYear());
const month = String(safeDate.getUTCMonth() + 1).padStart(2, "0");
const day = String(safeDate.getUTCDate()).padStart(2, "0");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Derive the report date in the production timezone

For samples opened between 00:00 and 05:29 in India, these UTC getters encode the previous calendar day, while production IDs use Asia/Kolkata in server-report-id-registry.js. The sample PDF can therefore show an ID dated one day earlier than its locally formatted generated date and than a production-shaped ID created at the same moment; format the ID date using the production timezone instead.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant