Refine sample report formatting and add sample Report ID - #180
Refine sample report formatting and add sample Report ID#180hrtechifyed wants to merge 6 commits into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
growwithhr-version2 | dd39217 | Aug 18 2026, 01:33 PM |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd39217a68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .sample-advisory-page .section { | ||
| padding: clamp(44px, 5vw, 64px) 0; |
There was a problem hiding this comment.
Raise the specificity of the sample layout overrides
The existing body[data-active-nav="sample"] .section rule in css/19-presentation-polish.css has higher specificity than this selector, so at the new test's 1440px viewport the section padding remains 96px rather than the intended maximum of 64px. The same specificity problem leaves .executive-profile-strip at six columns and keeps explanatory paragraphs centered, causing the newly added desktop Playwright assertions for padding, five columns, and heading alignment to fail; these overrides need at least the specificity of the existing body[data-active-nav="sample"] rules.
Useful? React with 👍 / 👎.
| const year = String(safeDate.getUTCFullYear()); | ||
| const month = String(safeDate.getUTCMonth() + 1).padStart(2, "0"); | ||
| const day = String(safeDate.getUTCDate()).padStart(2, "0"); |
There was a problem hiding this comment.
Derive the report date in the production timezone
For samples opened between 00:00 and 05:29 in India, these UTC getters encode the previous calendar day, while production IDs use Asia/Kolkata in server-report-id-registry.js. The sample PDF can therefore show an ID dated one day earlier than its locally formatted generated date and than a production-shaped ID created at the same moment; format the ID date using the production timezone instead.
Useful? React with 👍 / 👎.
What changed
sample-advisory-report.htmlwithout changing report content or functionality..sample-advisory-page.Sample Report IDusing the sameGWHR-YYYY-MMDD-XXXXshape as production IDs, with a clearly sample-onlySM01suffix./api/report-id, so viewing/downloading a sample never consumes or advances the production Report ID sequence.Regression protection