fix: keep 404 metadata off the homepage - #15
Merged
Conversation
Root layout kept the homepage title, canonical, and indexable robots, so unmatched routes reused that identity. Move homepage identity onto the homepage and give not-found its own noindex page.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadataBase, title template, application name, default social image). Homepage title, description, canonical/, indexable robots, and homepageog:title/og:url/og:descriptionlive onapp/page.tsx.not-found.tsxpublishesPage not found, a 404 description, andnoindex. Missing URLs no longer reuse the homepage canonical or indexable robots.Test plan
bun run check(typecheck, lint, full test suite)next start --port 4013curl of/, a missing path,/about, and/history/acquisitionsPage not found | stripehistory.com, robots arenoindex, no homepage canonical, noog:urlpointing athttps://stripehistory.com