Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Hotfix for issue #590#1281

Closed
izotos wants to merge 1 commit into
howdyai:legacyfrom
izotos:issue-590-hotfix
Closed

Hotfix for issue #590#1281
izotos wants to merge 1 commit into
howdyai:legacyfrom
izotos:issue-590-hotfix

Conversation

@izotos

@izotos izotos commented Mar 8, 2018

Copy link
Copy Markdown

Possible fix for #590

@johman10

johman10 commented May 2, 2018

Copy link
Copy Markdown

I confirm that this fixes the issue mentioned in #590. Is there any chance this will get merged?

@peterswimm

Copy link
Copy Markdown
Contributor

Has anyone been able to confirm it does not BREAK other aspects of the Slack integration?

@johman10

johman10 commented May 2, 2018

Copy link
Copy Markdown

@peterswimm which features should be tested to make sure this doesn't break anything? I can probably test it if I have a bit more of a scope.

@erodewald

Copy link
Copy Markdown

Happy to help verify as well @peterswimm, just not sure what specifically. We're using this PR internally for a slash command exclusively with no issues.

@izotos

izotos commented May 3, 2018

Copy link
Copy Markdown
Author

@peterswimm I can also confirm this works for us as well, though we only use it in our development env. Also unsure what I should be testing, I can just list the things that do work in our applications:

  • API calls (bot.api.)
  • Interactive messages (replyInteractive, replyInThread)
  • Dialog (replyWithDialog) which fails in current version

jnv added a commit to jnv/botkit that referenced this pull request May 23, 2018
@benbrown benbrown changed the base branch from master to legacy May 3, 2019 21:00
@benbrown benbrown added the legacy pertaining to version 0.7 or below label May 4, 2019
@ryansydnor

Copy link
Copy Markdown
Contributor

This is handled more comprehensively by #1453. Closing in favor of that PR.

@ryansydnor ryansydnor closed this Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug legacy pertaining to version 0.7 or below Slack-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants