fix(auth): declare 'loginparams' capability so the server selector works regardless of auth driver#91
Conversation
works regardless of auth driver
IMP_Application::authLoginParams() (which builds the server selector
when $conf['server']['server_list'] = 'shown') was only reachable via
Horde_Core_Auth_Application::getLoginParams() when the Horde auth
driver was 'application' pointed at imp. Declaring 'loginparams' in
$auth lets horde/base's LoginService/login.php resolve these params
independently, via hasCapability('loginparams').
|
Thanks for the PR! I looked at this together with the companion PR horde/base#136 (this change is only effective in combination with it — nothing in the currently shipped code checks Mechanically the capability declaration works: However, I think the pair of PRs doesn't fully fix the underlying problem — see my detailed comment on horde/base#136. Short version: with a non- The root cause is more likely a small omission in |
IMP_Application::authLoginParams() (which builds the server selector when $conf['server']['server_list'] = 'shown') was only reachable via Horde_Core_Auth_Application::getLoginParams() when the Horde auth driver was 'application' pointed at imp. Declaring 'loginparams' in $auth lets horde/base's LoginService/login.php resolve these params independently, via hasCapability('loginparams').