fix: honour tokenEndpointAuthMethodsSupported in revokeToken()#5
Merged
Merged
Conversation
Follows up on horde#4. RFC 7009 §2.1 does not prescribe the client authentication method for the revocation endpoint. Providers that advertise client_secret_basic only will reject a request that sends credentials in the POST body. Apply the same tokenEndpointAuthMethodsSupported check as tokenRequest(): use HTTP Basic when client_secret_basic is advertised exclusively, fall back to client_secret_post otherwise. Adds two tests covering the Basic and mixed-methods cases.
Member
|
Thank you! |
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #4.
RFC 7009 §2.1 does not prescribe the client authentication method for the revocation endpoint. Providers that advertise client_secret_basic only will reject a request that sends credentials in the POST body.
Apply the same tokenEndpointAuthMethodsSupported check as tokenRequest(): use HTTP Basic when client_secret_basic is advertised exclusively, fall back to client_secret_post otherwise.
Adds two tests covering the Basic and mixed-methods cases.