fix(activesync): guard ResolveRecipients free/busy lookup failures#200
Merged
TDannhauer merged 1 commit intoJul 16, 2026
Merged
Conversation
When calendar free/busy lookup fails (common for external addresses without a free/busy URL), return a keyed false result and only log at debug. Guard the driver against non-array connector results so availability requests no longer trigger PHP array-offset warnings.
ralflang
added a commit
that referenced
this pull request
Jul 18, 2026
Release version 3.2.1 fix(core): preserve descriptor schemas in ApiRegistry re-wrapping Merge pull request #200 from horde/fix/activesync-resolve-recipient-freebusy fix(activesync): guard ResolveRecipients free/busy lookup failures fix(core): preserve Unix socket SQL config in DbServiceFactory fix(core): keep Horde_Session::$begin readable after close() (imp#88)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Clients often request availability for addresses that have no free/busy
data (especially external invitees without a free/busy URL). The connector
returned bare
false, and the driver indexed it as an array, producingTrying to access array offset on falsein the Horde log.Changes
lookupFreeBusyfailure, log at debug and return[$query => false]$fb[$search]when$fbis an array with that keyDriverResolveRecipientTestfor both failure shapesTest plan
DriverResolveRecipientTest(2 tests)