Skip to content

fix(prefs): guard config-file storage against null $registry global #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralflang merged 1 commit into from
Jul 8, 2026
Merged

fix(prefs): guard config-file storage against null $registry global #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/Horde/Core/Prefs/Storage/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,17 @@ public function get($scope_ob)
{
global $registry;

/* Modern PSR-15 request paths (e.g. the admin REST API) never
* populate $GLOBALS['registry']. Config-file defaults are a
* best-effort layer atop user prefs; when we cannot reach the
* registry, return the scope unchanged and let downstream
* storage drivers (SQL etc.) supply real values. Same graceful
* fallback shape as the try/catch below for missing prefs.php
* files. */
if (!$registry instanceof Horde_Registry) {
return $scope_ob;
}

/* Read the configuration file.
* Values are in the $_prefs array. */
try {
Expand Down
Loading