feat(activesync): persist folder UID map across FolderSync resets#87
Open
TDannhauer wants to merge 1 commit into
Open
feat(activesync): persist folder UID map across FolderSync resets#87TDannhauer wants to merge 1 commit into
TDannhauer wants to merge 1 commit into
Conversation
Keep backend-id to EAS-uid assignments in SyncCache foldermap and stop FolderSync synckey=0 from clear+saving an empty folders map so concurrent SYNC/PING do not hit FolderGone. Reconcile stale folders after a full hierarchy export.
🔍 CI ResultsOverall: ❌ 12/12 lanes failed TL;DR: ❌ Quality issues: PHPUnit: 60 tests failed; PHPStan: 332 unique errors in 8 lanes; PHP-CS-Fixer: 21 files. Summary by PHP Version
Quality Metrics
❌ Failed Lanesphp8.0-dev
php8.0-stable
php8.1-dev
php8.1-stable
php8.2-dev
php8.2-stable
php8.3-dev
php8.3-stable
php8.4-dev
php8.4-stable
php8.5-dev
php8.5-stable
CI powered by horde-components • View full results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
foldermap(backend_serverid→eas_folder_uid) across FolderSync rebuildssynckey=0reset from clearing/saving an empty folders map mid-rebuilddoc/todo.md; unit coverage inFolderUidMapPersistenceTestMotivation
Concurrent iOS ActiveSync sessions often issue FolderSync with
synckey=0after hierarchy changes. Clearing and persisting an emptyfoldersmap raced parallel SYNC/PING into FolderGone / unstable sync. Deterministic UID generation (#81) mitigated divergent UIDs but not map loss on clear.Independent of streaming (#84) and idempotent import (#86). Touches the same
State/{Base,Sql,Mongo}.phpfiles as #86 in different regions — rebase if both merge closely.Changes
SyncCache:foldermap, seed/reconcile helpers;clearFolders()keeps the mapStateSql/Mongo: FolderSync reset keeps folders + foldermapState_Base: prefer foldermap ingetFolderUidToBackendIdMap();rememberFolderUid/resetFolderUidMapCollections/FolderSync: lookup fallback and post-export reconciledoc/todo.md,FolderUidMapPersistenceTestTest plan
FolderUidMapPersistenceTest(deployment PHPUnit)keeping folders + foldermap; no ghost folder / status 12 during initial syncsynckey=0while SYNC/PING run — no FolderGone storm for known UIDs