Skip to content

fix(activesync): guard empty OOF messages in Settings response #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TDannhauer merged 1 commit into from
Jul 13, 2026
Merged

fix(activesync): guard empty OOF messages in Settings response #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/Horde/ActiveSync/Request/Settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,9 +350,19 @@ protected function _getOofObject($info)
}
$msg = Horde_ActiveSync::messageFactory('OofMessage');
$msg->internal = '';
$msg->enabled = $info['oofmsgs'][0]['enabled'] ? 1 : "0";
$msg->reply = $info['oofmsgs'][0]['replymessage'];
$msg->bodytype = 'text';
$oofMsgs = $info->get('oofmsgs', []);
$oofMsg = (is_array($oofMsgs) && array_key_exists(0, $oofMsgs))
? $oofMsgs[0]
: null;
if (is_array($oofMsg)) {
$msg->enabled = $oofMsg['enabled'] ? 1 : '0';
$msg->reply = $oofMsg['replymessage'] ?? '';
$msg->bodytype = $oofMsg['bodytype'] ?? 'text';
} else {
$msg->enabled = '0';
$msg->reply = '';
$msg->bodytype = 'text';
}
$oof->messages[] = $msg;

return $oof;
Expand Down
74 changes: 74 additions & 0 deletions test/unit/Horde/ActiveSync/Request/SettingsRequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
<?php

/**
* Unit tests for Horde_ActiveSync_Request_Settings helpers.
*
* @author Torben Dannhauer <torben@dannhauer.de>
* @license http://www.horde.org/licenses/gpl GPLv2
* @copyright 2026 The Horde Project (http://www.horde.org/)
* @package ActiveSync
*/

namespace Horde\ActiveSync\Request;

use Horde_ActiveSync_Request_Settings;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\TestCase;
use ReflectionClass;

#[CoversClass(Horde_ActiveSync_Request_Settings::class)]
class SettingsRequestTest extends TestCase
{
public function testGetOofObjectDefaultsWhenNoMessagesConfigured()
{
$oof = $this->_getOofObject([
'status' => Horde_ActiveSync_Request_Settings::STATUS_SUCCESS,
'oofstate' => Horde_ActiveSync_Request_Settings::OOF_STATE_DISABLED,
'oofmsgs' => [],
]);

$this->assertSame(
Horde_ActiveSync_Request_Settings::OOF_STATE_DISABLED,
$oof->state
);
$this->assertCount(1, $oof->messages);
$this->assertSame('0', $oof->messages[0]->enabled);
$this->assertSame('', $oof->messages[0]->reply);
$this->assertSame('text', $oof->messages[0]->bodytype);
}

public function testGetOofObjectUsesConfiguredMessage()
{
$oof = $this->_getOofObject([
'status' => Horde_ActiveSync_Request_Settings::STATUS_SUCCESS,
'oofstate' => Horde_ActiveSync_Request_Settings::OOF_STATE_ENABLED,
'oofmsgs' => [
[
'enabled' => true,
'replymessage' => 'Out of office.',
'bodytype' => 'HTML',
],
],
]);

$this->assertSame(1, $oof->messages[0]->enabled);
$this->assertSame('Out of office.', $oof->messages[0]->reply);
$this->assertSame('HTML', $oof->messages[0]->bodytype);
}

/**
* @param array $info
*
* @return \Horde_ActiveSync_Message_Oof
*/
protected function _getOofObject(array $info)
{
$request = (new ReflectionClass(Horde_ActiveSync_Request_Settings::class))
->newInstanceWithoutConstructor();
$method = (new ReflectionClass(Horde_ActiveSync_Request_Settings::class))
->getMethod('_getOofObject');
$method->setAccessible(true);

return $method->invoke($request, $info);
}
}
Loading