Fix infrared NEC test command to a valid 8-bit value#176573
Merged
abmantis merged 2 commits intoJul 15, 2026
Merged
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
Author
|
This is split out as its own PR (rather than folded into the dependency-bump PR) per the Home Assistant policy that a PR should fix only one thing and unrelated changes belong in separate PRs. |
21 tasks
tr4nt0r
reviewed
Jul 15, 2026
Co-authored-by: Manu <tr4nt0r@uber.space>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
tests/components/infrared/test_init.pydefined its module-levelTEST_COMMANDwithcommand=0x08F7, which is not a valid 8-bit NEC command. Until now theinfrared-protocolslibrary silently masked it (command & 0xFF→0xF7), so the invalid literal went unnoticed.In infrared-protocols 7.1.0, the library added explicit range validation for NEC address/command bytes (home-assistant-libs/infrared-protocols#68, commit home-assistant-libs/infrared-protocols@eb7987ba751), which now raises
ValueError: command must be an 8-bit value (0-0xFF), got 0x8f7at test-collection time when the library is upgraded past 7.0.0.This changes the constant to
command=0x00F7(0xF7), which is the exact value the encoder always used (the high byte was previously discarded by the mask), so the test's behavior is unchanged. It is valid under the current pinned 7.0.0 as well, so this PR is safe ondevtoday.Type of change
Additional information
infrared-protocolsto 7.2.0 and currently fails CI on this collection errorChecklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: