Skip to content

Correct water_price sensor for suez_water: price is per m³#170898

Closed
alaunay wants to merge 11 commits into
home-assistant:devfrom
alaunay:dev
Closed

Correct water_price sensor for suez_water: price is per m³#170898
alaunay wants to merge 11 commits into
home-assistant:devfrom
alaunay:dev

Conversation

@alaunay

@alaunay alaunay commented May 16, 2026

Copy link
Copy Markdown

Proposed change

Modify the type of sensor for the suez_water integration: the price is per 1000L (or m³).
Current sensor price cannot be used in the water energy dashboard.

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Copilot AI review requested due to automatic review settings May 16, 2026 12:49

@home-assistant home-assistant Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alaunay

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant Bot marked this pull request as draft May 16, 2026 12:49
@home-assistant

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @ooii, @jb101010-2, mind taking a look at this pull request as it has been labeled with an integration (suez_water) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of suez_water can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign suez_water Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the water_price sensor's unit of measurement to include volume denominator.

Changes:

  • Change native_unit_of_measurement from CURRENCY_EURO constant to a string literal containing unformatted placeholders.

Comment thread homeassistant/components/suez_water/sensor.py Outdated
@issue-triage-workflows

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

Copilot AI review requested due to automatic review settings July 16, 2026 09:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread homeassistant/components/suez_water/sensor.py Outdated
Comment thread homeassistant/components/suez_water/sensor.py
Comment thread homeassistant/components/suez_water/sensor.py
Copilot AI review requested due to automatic review settings July 16, 2026 09:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread homeassistant/components/suez_water/sensor.py
Comment thread homeassistant/components/suez_water/sensor.py
Comment thread homeassistant/components/suez_water/sensor.py
Copilot AI review requested due to automatic review settings July 16, 2026 09:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread homeassistant/components/suez_water/sensor.py
Comment thread homeassistant/components/suez_water/sensor.py
Copilot AI review requested due to automatic review settings July 16, 2026 10:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread homeassistant/components/suez_water/sensor.py
Comment thread homeassistant/components/suez_water/sensor.py
Copilot AI review requested due to automatic review settings July 16, 2026 10:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread tests/components/suez_water/snapshots/test_sensor.ambr
Comment thread homeassistant/components/suez_water/sensor.py
Copilot AI review requested due to automatic review settings July 16, 2026 10:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread homeassistant/components/suez_water/sensor.py
Copilot AI review requested due to automatic review settings July 16, 2026 11:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 16, 2026 11:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 16, 2026 11:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

"loggers": ["aioshelly"],
"quality_scale": "platinum",
"requirements": ["aioshelly==13.26.2"],
"requirements": ["aioshelly==13.27.0"],
Comment thread requirements_all.txt

# homeassistant.components.shelly
aioshelly==13.26.2
aioshelly==13.27.0
@alaunay alaunay closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants