change wording on android version requirement#1197
change wording on android version requirement#1197harmpter wants to merge 1 commit intohome-assistant:masterfrom
Conversation
Android 12 or older -> Android 12 or below
|
Thanks for the suggestion. However, the documentation consistently uses "or older" for this kind of requirement, and in the text it is still a 5 letter word so I don't really see how this is less easily confused. While the issues you linked are relevant, they are created around the time the change occurred. As such I believe the update changing the behavior is the reason for the issues, rather than the documentation. |
|
Thank you! I see, I wasn't aware of that. Regarding the semantics; while "or older" is definitely not incorrect, it is easy to make the mistake of thinking of it as "greater number = greater age = older" because that's how age usually works. But I now recognize and agree that the issues were created around the time Android 13 rolled out, that's fair and I missed that. Can I add another commit to this pull to at least keep the wording consistent across the documentation? If yes, I will try to do that. Please let me know what you think about the older/below/earlier thingy. |
|
Looking at the style guide recently adopted for Home Assistant documentation for earlier, it looks like that's the way to go:
There are a lot of places where "or older" is currently used - so if you want to update it, please update it everywhere for consistency. |
Android 12 or older -> Android 12 or below
Proposed change
Hi, this is my first pull request and I hope I'm doing it correctly.
The docs point out that
command_bluetoothonly works on android versions Android 12 or older, which is easily confused for Android 12+ in a rush. I would like to change the word "older" to "below", as I find it more straightforward and prevents misunderstanding of the fact, that it only works up until Android 12, not from Android 12+ and above.Type of change
Checklist
Additional information