fix: require explicit throwing of LuaState errors#12
Open
pcbzzz wants to merge 1 commit into
Open
Conversation
pcbzzz
force-pushed
the
fix/lua-state-error-helpers
branch
from
e274afa to
b0a8021
Compare
pcbzzz
changed the title
pcbzzz
force-pushed
the
fix/lua-state-error-helpers
branch
from
b0a8021 to
ab43472
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codebase seems to expect LuaState#error to be self throwing, but 3cf6eb6 changed two of the three to return instead of throw.After tinkering a bit more and running into other issues, it definitely seems more appropriate to go the opposite direction and make callers throw instead