Set fields to delete explicitly to null instead of undefined#45
Open
luizcarlos1405 wants to merge 1 commit into
Open
Set fields to delete explicitly to null instead of undefined#45luizcarlos1405 wants to merge 1 commit into
luizcarlos1405 wants to merge 1 commit into
Conversation
Dsyko
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use Meteor at work, and it configures the MongoDB drivers to ignore
undefinedvalues when updating a field instead of setting the field tonull(unlike the MongoDB driver, which does not ignoreundefinedby default).This behavior caused a specific issue where the same job document was repeatedly fetched, resulting in a job running in a loop until the lock is released due to the end of the lock time. The document would match because of the second condition in this
$orquery, as thelockedAtfield wasn't set tonullas expected:agenda/src/JobDbRepository.ts
Lines 133 to 146 in 16a7e8b
However, explicitly setting the fields to
nullinstead ofundefinedis a better practice because, in the end, they turn intonullin the database. Also, not ignoringundefinedand turning it intonullfeels weeeiiiird.If someone else is facing the same issue, a possible fix is adding this option to your
settings.jsonfile:This configuration ensures that setting a field to
undefinedactually sets it tonull. But please note that if you have code relying on the previous behavior, this fix could potentially break something else.