WIP: Jest javascript test suite#1
Open
MichaelDimmitt wants to merge 10 commits into
Open
Conversation
4ea0feb to
df09624
Compare
MichaelDimmitt
commented
May 16, 2019
| } | ||
| catch (e){ | ||
| console.log({e}) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Here I am catching the error:
bash command sends exit code 1: "File does not exist"
command that works:
rest_easy list --targets ./.example.targets.json --log ./rest_easy.log && cat rest_easy.log
command that does not work:
rest_easy list
Maybe this should be written into a test to ensure default environment is correct. In my case default is somehow set to ~/go/bin.
rest_easy list --help
# --targets string JSON formatted targets file (default is ./targets.json)I am receiving error:
File does not exist: /Users/michaeldimmitt/go/bin/targets.json, exiting.
This may be do to my gopath:
export GOPATH=$HOME/go;
export PATH=$PATH:$GOPATH/bin
Maybe it will be useful to have a test that lets the developer know their environment is setup different than the expected setup.
Collaborator
Author
There was a problem hiding this comment.
Maybe we will talk about this at C&C next week if the test suite is tough to grok at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.