Disable IM unconditionally at FakeVim install time#3653
Merged
Conversation
Disable WA_InputMethodEnabled once in TextEditWrapper::install() and block QEvent::InputMethod/InputMethodQuery in eventFilter(). The attribute alone is insufficient on Wayland where the compositor can still deliver IM events via the text-input protocol. Together these prevent the platform IM framework from intercepting key presses, which broke undo grouping (each character became a separate undo step) and visual-block insert replay. Remove the per-mode-change workarounds that were insufficient: - setInsertMode() method and m_insertMode member - modeChanged signal connection - QInputMethodEvent include Assisted-by: Claude (Anthropic)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3653 +/- ##
==========================================
+ Coverage 74.34% 74.57% +0.22%
==========================================
Files 256 256
Lines 37970 37968 -2
Branches 5123 5121 -2
==========================================
+ Hits 28230 28314 +84
+ Misses 9740 9654 -86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable WA_InputMethodEnabled once in TextEditWrapper::install() and block QEvent::InputMethod/InputMethodQuery in eventFilter(). The attribute alone is insufficient on Wayland where the compositor can still deliver IM events via the text-input protocol. Together these prevent the platform IM framework from intercepting key presses, which broke undo grouping (each character became a separate undo step) and visual-block insert replay.
Remove the per-mode-change workarounds that were insufficient:
Assisted-by: Claude (Anthropic)