Fix FakeVim regressions after upstream sync#3651
Merged
Merged
Conversation
- Block all input method events (including preedit and query) in command mode. On Wayland compositors with press-and-hold for alternative characters (KDE Plasma 6.7+), key events are intercepted at the compositor level: preedit events trigger an alternatives popup and commit events insert text, both bypassing FakeVim's QKeyEvent filter. Suppress the entire IM interaction in command mode and route any committed text through FakeVim's input handler. Toggle WA_InputMethodEnabled based on the current FakeVim mode so IM features remain available in insert mode. - Implement the tabPressedInInsertMode callback added upstream, which now gates Tab key handling in insert mode. - Implement the processOutput callback that replaced the removed getProcessOutput() function, restoring shell command execution for filter and bang commands. Assisted-by: Claude (Anthropic)
hluk
force-pushed
the
fix-fakevim-tab-insert
branch
from
48793a5 to
9805092
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (45.71%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3651 +/- ##
==========================================
- Coverage 74.33% 74.32% -0.01%
==========================================
Files 256 256
Lines 37938 37970 +32
Branches 5115 5120 +5
==========================================
+ Hits 28202 28222 +20
- Misses 9736 9748 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block all input method events (including preedit and query) in command mode. On Wayland compositors with press-and-hold for alternative characters (KDE Plasma 6.7+), key events are intercepted at the compositor level: preedit events trigger an alternatives popup and commit events insert text, both bypassing FakeVim's QKeyEvent filter. Suppress the entire IM interaction in command mode and route any committed text through FakeVim's input handler. Toggle WA_InputMethodEnabled based on the current FakeVim mode so IM features remain available in insert mode.
Implement the tabPressedInInsertMode callback added upstream, which now gates Tab key handling in insert mode.
Implement the processOutput callback that replaced the removed getProcessOutput() function, restoring shell command execution for filter and bang commands.
Assisted-by: Claude (Anthropic)