Support import "filename" as ModuleName syntax#482
Merged
Hidden character warning
The head ref may contain hidden characters: "import\ud83c\udf45"
Conversation
LPTK
requested changes
Apr 29, 2026
Contributor
LPTK
left a comment
LPTK
left a comment
There was a problem hiding this comment.
There's redundancy in the logic. Can't you just remove the parser changes? You need to add more negative test cases.
Co-authored-by: Lionel Parreaux <lionel.parreaux@gmail.com>
LPTK
reviewed
Apr 29, 2026
Co-authored-by: Lionel Parreaux <lionel.parreaux@gmail.com>
LPTK
requested changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be used in #461.