perf(sync-client): continuously drain pushes with pull priority - #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A slow upload could hold the next selection of queued files behind the current 100-entry batch, and incoming pull requests had to wait for a push invocation of up to 1,000 mutations. Continuously replenish available push slots and yield to pending pulls after started work settles.
Validation
Benchmark comparison
Local five-sample means against the preceding ready-batch implementation, using the unchanged mixed fixture and simulated slow-attachment transport:
Upload attempts and encrypted bytes are unchanged. The 1 GiB push mean remains approximately 1.16 s. These are local simulated-transport measurements; process-wide RSS samples do not establish a memory improvement. Pull priority is cooperative: already-started uploads are joined, not cancelled.