Skip to content

test: add authenticated upload e2e flow - #44

Merged
hhhjin merged 1 commit into
mainfrom
codex/e2e-auth-upload-tests
Apr 12, 2026
Merged

test: add authenticated upload e2e flow#44
hhhjin merged 1 commit into
mainfrom
codex/e2e-auth-upload-tests

Conversation

@hhhjin

@hhhjin hhhjin commented Apr 12, 2026

Copy link
Copy Markdown
Member

Summary

  • add a Playwright-authenticated upload flow with shared auth bootstrap helpers
  • add test-only auth routes for seeding an authenticated Better Auth session in E2E
  • update preview/proxy setup so production-style E2E runs can cover authenticated and anonymous upload paths

Testing

  • pnpm test:e2e -- --project=chromium e2e/authenticated-upload.spec.ts
  • pnpm test:e2e -- --project=chromium e2e/public-upload.spec.ts

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an end-to-end (E2E) testing framework using Playwright, specifically focusing on authenticated upload flows. It adds a dedicated test authentication router to simulate user sessions, updates the frontend to provide a readiness signal for tests, and configures Playwright to handle authenticated states. The review feedback identifies a critical issue in the test authentication route where Hono's signed cookie utilities are used for Better Auth session tokens; since Better Auth expects raw tokens, the signatures appended by Hono would cause authentication to fail.

Comment thread server/routes/test-auth.route.ts
Comment thread server/routes/test-auth.route.ts
Comment thread server/routes/test-auth.route.ts
@hhhjin
hhhjin merged commit 4357599 into main Apr 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant